Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: also run chmod on EPERM #1725

Merged
merged 2 commits into from Dec 6, 2020
Merged

util: also run chmod on EPERM #1725

merged 2 commits into from Dec 6, 2020

Commits on Dec 6, 2020

  1. util: also run chmod on EPERM

    Writing a test for this one is tricky, because I was seeing the issue
    only when the directory being removed is a docker volume, so instead of
    getting EACCES we get EPERM.
    
    This is easy to reproduce though. The existing test fails when the
    directory being used for the files is a docker volume:
    
    ```
    % docker run \
    	-v $(mktemp -d):/tmp \
    	-v ${PWD}:/src \
    	-w /src \
    	python:3 \
    	bash -c 'pip install -e . && pip install -r requirements-dev.txt && python -m pytest tests/util_test.py'
    ```
    fsouza committed Dec 6, 2020
    Copy the full SHA
    bb0d957 View commit details
    Browse the repository at this point in the history
  2. util: use set instead of tuple in errno check

    Co-authored-by: Paul Fischer <70564747+paulhfischer@users.noreply.github.com>
    fsouza and paulhfischer committed Dec 6, 2020
    Copy the full SHA
    c598785 View commit details
    Browse the repository at this point in the history