Skip to content

Commit

Permalink
always use #!/bin/sh on windows
Browse files Browse the repository at this point in the history
  • Loading branch information
asottile committed Jan 5, 2022
1 parent cccbc9d commit e3dc3f7
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
7 changes: 7 additions & 0 deletions pre_commit/commands/install_uninstall.py
Expand Up @@ -82,6 +82,13 @@ def _install_hook_script(
before, rest = contents.split(TEMPLATE_START)
_, after = rest.split(TEMPLATE_END)

# on windows always use `/bin/sh` since `bash` might not be on PATH
# though we use bash-specific features `sh` on windows is actually
# bash in "POSIXLY_CORRECT" mode which still supports the features we
# use: subshells / arrays
if sys.platform == 'win32': # pragma: win32 cover
hook_file.write('#!/bin/sh\n')

hook_file.write(before + TEMPLATE_START)
hook_file.write(f'INSTALL_PYTHON={shlex.quote(sys.executable)}\n')
# TODO: python3.8+: shlex.join
Expand Down
2 changes: 1 addition & 1 deletion requirements-dev.txt
@@ -1,4 +1,4 @@
covdefaults>=2.1
covdefaults>=2.2
coverage
distlib
pytest
Expand Down

0 comments on commit e3dc3f7

Please sign in to comment.