Skip to content

Commit

Permalink
Merge pull request #1735 from pre-commit/allow_ci_key
Browse files Browse the repository at this point in the history
allow configuration for pre-commit.ci
  • Loading branch information
asottile committed Dec 18, 2020
2 parents 2d54ea1 + 38a4a0a commit 8670d0b
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 0 deletions.
4 changes: 4 additions & 0 deletions pre_commit/clientlib.py
Expand Up @@ -297,9 +297,13 @@ def warn_unknown_keys_repo(
'exclude',
'fail_fast',
'minimum_pre_commit_version',
'ci',
),
warn_unknown_keys_root,
),

# do not warn about configuration for pre-commit.ci
cfgv.OptionalNoDefault('ci', cfgv.check_type(dict)),
)


Expand Down
14 changes: 14 additions & 0 deletions tests/clientlib_test.py
Expand Up @@ -166,6 +166,20 @@ def test_validate_warn_on_unknown_keys_at_top_level(tmpdir, caplog):
]


def test_ci_map_key_allowed_at_top_level(caplog):
cfg = {
'ci': {'skip': ['foo']},
'repos': [{'repo': 'meta', 'hooks': [{'id': 'identity'}]}],
}
cfgv.validate(cfg, CONFIG_SCHEMA)
assert not caplog.record_tuples


def test_ci_key_must_be_map():
with pytest.raises(cfgv.ValidationError):
cfgv.validate({'ci': 'invalid', 'repos': []}, CONFIG_SCHEMA)


def test_validate_optional_sensible_regex(caplog):
config_obj = {
'id': 'flake8',
Expand Down

0 comments on commit 8670d0b

Please sign in to comment.