Add test_get_root_not_in_working_dir()

pre-commit · Feb 18, 2022 · 60bc363 · 60bc363
1 parent 9a309ac
commit 60bc363
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/pre_commit/git.py b/pre_commit/git.py
@@ -88,8 +88,7 @@ def get_git_common_dir(git_root: str = '.') -> str:
     git_common_dir = out.strip()
     if git_common_dir != opt:
         return os.path.normpath(os.path.join(git_root, git_common_dir))
-    else:
-        # pragma: no branch (git < 2.5)
+    else:  # pragma: no cover (git < 2.5)
         return get_git_dir(git_root)
 
 

diff --git a/tests/git_test.py b/tests/git_test.py
@@ -28,6 +28,13 @@ def test_get_root_in_git_sub_dir(in_git_dir):
             assert os.path.normcase(git.get_root()) == expected
 
 
+def test_get_root_not_in_working_dir(in_git_dir):
+    expected = os.path.normcase(in_git_dir.strpath)
+    with pytest.raises(FatalError):
+        with in_git_dir.join('..').ensure_dir().as_cwd():
+            assert os.path.normcase(git.get_root()) == expected
+
+
 def test_in_exactly_dot_git(in_git_dir):
     with in_git_dir.join('.git').as_cwd(), pytest.raises(FatalError):
         git.get_root()