Skip to content

Commit

Permalink
Merge pull request #2484 from pre-commit/allow-files-when-unmerged
Browse files Browse the repository at this point in the history
allow `pre-commit run --files ...` against unmerged files
  • Loading branch information
asottile committed Aug 15, 2022
2 parents 6740a17 + 2405caa commit 51e6d65
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
2 changes: 1 addition & 1 deletion pre_commit/commands/run.py
Expand Up @@ -333,7 +333,7 @@ def run(
stash = not args.all_files and not args.files

# Check if we have unresolved merge conflict files and fail fast.
if _has_unmerged_paths():
if stash and _has_unmerged_paths():
logger.error('Unmerged files. Resolve before committing.')
return 1
if bool(args.from_ref) != bool(args.to_ref):
Expand Down
7 changes: 7 additions & 0 deletions tests/commands/run_test.py
Expand Up @@ -536,6 +536,13 @@ def test_merge_conflict(cap_out, store, in_merge_conflict):
assert b'Unmerged files. Resolve before committing.' in printed


def test_files_during_merge_conflict(cap_out, store, in_merge_conflict):
opts = run_opts(files=['placeholder'])
ret, printed = _do_run(cap_out, store, in_merge_conflict, opts)
assert ret == 0
assert b'Bash hook' in printed


def test_merge_conflict_modified(cap_out, store, in_merge_conflict):
# Touch another file so we have unstaged non-conflicting things
assert os.path.exists('placeholder')
Expand Down

0 comments on commit 51e6d65

Please sign in to comment.