Skip to content

Commit

Permalink
Merge pull request #2030 from pre-commit/duplicate-messages-autoupdate
Browse files Browse the repository at this point in the history
remove duplicate warnings while running autoupdate
  • Loading branch information
asottile committed Aug 31, 2021
2 parents 25a1988 + 726f2ad commit 3bab151
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 17 deletions.
4 changes: 0 additions & 4 deletions pre_commit/commands/migrate_config.py
Expand Up @@ -3,7 +3,6 @@

import yaml

from pre_commit.clientlib import load_config
from pre_commit.util import yaml_load


Expand Down Expand Up @@ -40,9 +39,6 @@ def _migrate_sha_to_rev(contents: str) -> str:


def migrate_config(config_file: str, quiet: bool = False) -> int:
# ensure that the configuration is a valid pre-commit configuration
load_config(config_file)

with open(config_file) as f:
orig_contents = contents = f.read()

Expand Down
13 changes: 0 additions & 13 deletions tests/commands/migrate_config_test.py
@@ -1,7 +1,4 @@
import pytest

import pre_commit.constants as C
from pre_commit.clientlib import InvalidConfigError
from pre_commit.commands.migrate_config import migrate_config


Expand Down Expand Up @@ -130,13 +127,3 @@ def test_migrate_config_sha_to_rev(tmpdir):
' rev: v1.2.0\n'
' hooks: []\n'
)


@pytest.mark.parametrize('contents', ('', '\n'))
def test_migrate_config_invalid_configuration(tmpdir, contents):
cfg = tmpdir.join(C.CONFIG_FILE)
cfg.write(contents)
with tmpdir.as_cwd(), pytest.raises(InvalidConfigError):
migrate_config(C.CONFIG_FILE)
# even though the config is invalid, this should be a noop
assert cfg.read() == contents

0 comments on commit 3bab151

Please sign in to comment.