Skip to content

Commit

Permalink
Use 'go install' instead of 'go get'
Browse files Browse the repository at this point in the history
`go install` is the recommended way to install modules starting from go 1.16.
In go 1.18 `go get` cannot be used anymore to install packages [1]. go 1.18 is
not released yet.

[1] https://tip.golang.org/doc/go1.18#go-command
  • Loading branch information
schmir committed Dec 15, 2021
1 parent 097f2c8 commit 379db4c
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions pre_commit/languages/golang.py
Expand Up @@ -79,9 +79,11 @@ def install_environment(
gopath = directory
env = dict(os.environ, GOPATH=gopath)
env.pop('GOBIN', None)
cmd_output_b('go', 'get', './...', cwd=repo_src_dir, env=env)
cmd_output_b('go', 'install', './...', cwd=repo_src_dir, env=env)
for dependency in additional_dependencies:
cmd_output_b('go', 'get', dependency, cwd=repo_src_dir, env=env)
cmd_output_b(
'go', 'install', dependency, cwd=repo_src_dir, env=env,
)
# Same some disk space, we don't need these after installation
rmtree(prefix.path(directory, 'src'))
pkgdir = prefix.path(directory, 'pkg')
Expand Down

0 comments on commit 379db4c

Please sign in to comment.