Skip to content

Commit

Permalink
include the configured value in the language_version / additional_dep…
Browse files Browse the repository at this point in the history
…endencies error
  • Loading branch information
asottile committed Mar 30, 2022
1 parent 98b9b70 commit 2188c0f
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
8 changes: 5 additions & 3 deletions pre_commit/languages/helpers.py
Expand Up @@ -67,7 +67,8 @@ def environment_dir(d: str | None, language_version: str) -> str | None:
def assert_version_default(binary: str, version: str) -> None:
if version != C.DEFAULT:
raise AssertionError(
f'For now, pre-commit requires system-installed {binary}',
f'for now, pre-commit requires system-installed {binary} -- '
f'you selected `language_version: {version}`',
)


Expand All @@ -77,8 +78,9 @@ def assert_no_additional_deps(
) -> None:
if additional_deps:
raise AssertionError(
f'For now, pre-commit does not support '
f'additional_dependencies for {lang}',
f'for now, pre-commit does not support '
f'additional_dependencies for {lang} -- '
f'you selected `additional_dependencies: {additional_deps}`',
)


Expand Down
4 changes: 3 additions & 1 deletion tests/languages/helpers_test.py
Expand Up @@ -88,7 +88,9 @@ def test_assert_no_additional_deps():
helpers.assert_no_additional_deps('lang', ['hmmm'])
msg, = excinfo.value.args
assert msg == (
'For now, pre-commit does not support additional_dependencies for lang'
'for now, pre-commit does not support additional_dependencies for '
'lang -- '
"you selected `additional_dependencies: ['hmmm']`"
)


Expand Down

0 comments on commit 2188c0f

Please sign in to comment.