add golang package mirroring #165
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taoufik07
force-pushed
the
golang_mirror
branch
from
0a38303
to
a6f45e0
Compare
asottile
reviewed
Feb 16, 2023
| @@ -4,6 +4,7 @@ | |||
| import subprocess | |||
| import urllib.request | |||
|
|
|||
| import lxml.html | |||
There was a problem hiding this comment.
you should not need an external dependency to read xml -- there's an xml stdlib module
| @@ -0,0 +1,3 @@ | |||
| module github.com/pre-commit/dummy | |||
There was a problem hiding this comment.
please use the word "placeholder" instead as to avoid ableist language
| @@ -48,9 +64,11 @@ def rust_get_additional_dependencies( | |||
| 'python': python_get_package_versions, | |||
| 'ruby': ruby_get_package_versions, | |||
| 'rust': rust_get_package_versions, | |||
| 'golang': golang_get_package_versions, | |||
| @@ -66,7 +66,7 @@ def git(*cmd: str) -> None: | |||
| # Commit and tag | |||
| git('add', '.') | |||
| git('commit', '-m', f'Mirror: {version}') | |||
| git('tag', f'v{version}') | |||
| git('tag', f'v{version.lstrip("v")}') | |||
asottile
reviewed
Feb 16, 2023
Comment on lines
+36
to
+41
| url = f'https://pkg.go.dev/{package_name}?tab=versions' | ||
| resp = urllib.request.urlopen(url) | ||
| versions = lxml.html.parse(resp).xpath( | ||
| "//a[@class='js-versionLink']//text()", | ||
| ) | ||
| return [str(version) for version in versions[::-1]] |
There was a problem hiding this comment.
we should not be parsing html to get the answers here -- this needs to come from an actual documented api
There was a problem hiding this comment.
As far as I know, go doesn't provide an actual documented API, the only workaround was to scrape it : /
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.