Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow TOML 1.0.0 syntax in check-toml #608

Closed
wants to merge 1 commit into from
Closed

Allow TOML 1.0.0 syntax in check-toml #608

wants to merge 1 commit into from

Conversation

hukkin
Copy link

@hukkin hukkin commented Jun 2, 2021 •
edited

check-toml fails with new TOML 1.0.0 syntax. This changes the TOML parser used to a spec v1.0.0 compatible one. Disclaimer: the parser used is written by me.

@asottile
Copy link
Member

asottile commented Jun 2, 2021

no thanks, toml is the ubiquitous library used in the python community -- surely it will be updated at some point

@asottile asottile closed this Jun 2, 2021
@hukkin hukkin deleted the toml-1.0.0 branch June 2, 2021 14:16
@hukkin
Copy link
Author

hukkin commented Jun 2, 2021 •
edited

I respect that. You may be interested to know that Tomli is about to be vendored in pip, so pip will use it to read pyproject.toml.

@sognetic sognetic mentioned this pull request Apr 22, 2022
Closed
@DanielNoord
Copy link
Contributor

@asottile Seeing as tomli is now included as tomllib in 3.11, would you want a PR that switches to tomli similar to python/mypy#12305 / pytest-dev/pytest#9741?

@DanielNoord DanielNoord mentioned this pull request May 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hukkin @asottile @DanielNoord @hukkinj1