Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identify Cargo.toml and Cargo.lock as cargo and cargo-lock #455

Merged
merged 1 commit into from Apr 20, 2024
Merged

Identify Cargo.toml and Cargo.lock as cargo and cargo-lock #455

merged 1 commit into from Apr 20, 2024

Conversation

jalaziz
Copy link
Contributor

@jalaziz jalaziz commented Apr 15, 2024

Introduce dedicated types for Cargo.toml and Cargo.lock files. These are similar to go.mod and go.sum files.

@jalaziz
Copy link
Contributor Author

jalaziz commented Apr 15, 2024

I separated out Cargo.toml and Cargo.lock as separate types to match go.mod and go.sum, but maybe they should just be grouped under a single cargo type?

@jalaziz jalaziz changed the title Identity Cargo.toml and Cargo.lock as cargo and cargo-lock Identify Cargo.toml and Cargo.lock as cargo and cargo-lock Apr 15, 2024
@jalaziz
Identify Cargo.toml and Cargo.lock as cargo and cargo-lock
c0083af 
Introduce dedicated types for Cargo.toml and Cargo.lock files. These are
similar to go.mod and go.sum files.
asottile
asottile approved these changes Apr 20, 2024
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile asottile merged commit dab738c into pre-commit:main Apr 20, 2024
5 checks passed
@jalaziz jalaziz deleted the rust-cargo-tags branch April 20, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile asottile asottile approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jalaziz @asottile