Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #45

Closed
wants to merge 1 commit into from

Conversation

martinerko
Copy link

react-scripts v 5.0 is out there and it works perfectly

@pradel
Copy link
Owner

pradel commented Dec 20, 2021

Looks like craco is not yet supporting CRA 5, we should wait for them to support it before creating a new release here dilanx/craco#353

@martinerko
Copy link
Author

Looks like craco is not yet supporting CRA 5, we should wait for them to support it before creating a new release here gsoft-inc/craco#353

The issue seems to be with the craco-* plugins (such as craco-less).
I am already running this without any issue.
Check ths out
https://github.com/martinerko/react-scripts-typescript-craco-esbuild

@pradel
Copy link
Owner

pradel commented Dec 21, 2021

I created a pr adding an example running on CRA 5 but getting the following error during builds #48

Plugin "react" was conflicted between "package.json » eslint-config-react-app » /Users/leo/dev/github/pradel/create-react-app-esbuild/examples/cra-4/with-javascript/node_modules/eslint-config-react-app/base.js" and "BaseConfig » /Users/leo/dev/github/pradel/create-react-app-esbuild/node_modules/.pnpm/eslint-config-react-app@6.0.0_09f0dc14b8920a4aead8ce95b713775f/node_modules/eslint-config-react-app/base.js".

@pradel
Copy link
Owner

pradel commented Dec 21, 2021

Managed to fix this issue but now the svgr plugin is not working anymore

@pradel
Copy link
Owner

pradel commented Dec 21, 2021

Closing in favour of #48 as it requires some changes to have all the features working.

@pradel pradel closed this Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants