Add pre commit configuration with husky #163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 6, 2022 14:56
|
Thanks for opening this PR! We would appreciate it if you could provide us with more info about your PR 🙏 |
|
Add pre-commit configuration with Husky. |
relsteiner
reviewed
Jul 6, 2022
| @@ -1680,6 +1682,13 @@ | |||
| "pretty-format": "^27.0.0" | |||
| } | |||
| }, | |||
| "node_modules/@types/minimatch": { | |||
| "version": "3.0.5", | |||
| "resolved": "https://art-bobcat.autodesk.com:443/artifactory/api/npm/autodesk-npm-virtual/@types/minimatch/-/minimatch-3.0.5.tgz", | |||
There was a problem hiding this comment.
Looks like dependencies were install with art-bobcat registry which is not available outside of Autodesk's network. Can you please revert changes to package.lock file and try to reinstall dependencies (if you have any new dependencies) with the new npmrc file (added in a previous PR) which specifies the global npm registry.
There was a problem hiding this comment.
Fixed in this PR ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.