Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make default skin cursor more visible against bright backgrounds #9488

Merged
merged 7 commits into from
Jul 10, 2020

Conversation

peppy
Copy link
Sponsor Member

@peppy peppy commented Jul 10, 2020

  • Adds a dark colour to the centre (similar to stable) to make the default cursor more usable.
  • Fixes cursor scale potentially not being read (only happens in tests).
  • Fixes cursor tests not correctly showing transforms due to calling OnPressed/OnReleased too often.
  • Adds tests against random background colours (and user input driven tests).
  • Depends on Add the ability to disable the ManualInputManager cursor guide osu-framework#3706

This is not a final design, just a temporary usability improvement until we have a more definitive cursor design.

Copy link
Contributor

@smoogipoo smoogipoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, can read much better with this

@smoogipoo smoogipoo merged commit a0268b4 into ppy:master Jul 10, 2020
@peppy peppy deleted the osu-cursor-visibility branch July 14, 2020 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants