Remove localisation of "hide" string to fix incorrect case #17958
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found two more cases after looking again at my changes. Should be
|
bdach
approved these changes
Apr 24, 2022
|
Is this some language-specific nuance? Curious why hide was reverted but not "edit", which was changed alongside it in the breaking PR. |
|
Oh... It's just about title casing? We already have |
|
Because sentence casing is preferred over title casing in some cases, or at least that's why I think ppy/osu-framework#5127 was opened. |
|
Ah. Then the original question still remains for why "edit" wasn't reverted. |
|
Edit seems to be the correct case already in the localisation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.