Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix editor legacy beatmap skins not wrapped in LegacySkinTransformers #17856

Merged
merged 4 commits into from
Apr 18, 2022
Merged

Fix editor legacy beatmap skins not wrapped in LegacySkinTransformers #17856

merged 4 commits into from
Apr 18, 2022

Conversation

frenzibyte
Copy link
Member

See #17745 (comment) for details and discussion.

As concluded, EditorSkinProvidingContainer should pass the underlying beatmap skin instance to the skin source hierarchy for passing the pattern-match and get wrapped in a LegacySkinTransformer properly, rather than EditorBeatmapSkin which is only an ISkin wrapper.

@peppy peppy enabled auto-merge April 18, 2022 04:33
@peppy peppy disabled auto-merge April 18, 2022 05:39
@peppy peppy merged commit 587f1e2 into ppy:master Apr 18, 2022
@frenzibyte frenzibyte deleted the editor-beatmap-skin-legacy-transformer branch April 18, 2022 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peppy peppy

Assignees
No one assigned
Labels
area:editor area:skinning size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect slider follow circle size in editor with beatmap skins enabled
2 participants
@frenzibyte @peppy