Fix SkinnableSprites in storyboards not autosizing to the textures
#17238
+15
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
smoogipoo
approved these changes
Mar 14, 2022
| drawable = new SkinnableSprite(path) | ||
| { | ||
| RelativeSizeAxes = Axes.None, | ||
| AutoSizeAxes = Axes.Both, |
There was a problem hiding this comment.
This is potentially a scary amount of autosize and one would hope that this is a simple automatic operation that SkinableSprite does when no size/relative size is provided by just taking the Sprite's size...
But I guess this is fine?
There was a problem hiding this comment.
Yeah I'm not too sure about this myself, went with how it's done in other places like CatchComboDisplay and DrawableNote. The RelativeSizeAxes = Axes.Both specification in SkinnableDrawable would definitely have to be removed first to allow such automatic operation in place.
There was a problem hiding this comment.
Doesn't seem to have a noticeable effect in an edge case scenario I've got.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while adding test cases for #17237.