Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable Sourcelink support by fixing the condition. #2085

Merged
merged 1 commit into from
Jan 12, 2019
Merged

Reenable Sourcelink support by fixing the condition. #2085

merged 1 commit into from
Jan 12, 2019

Conversation

miterosan
Copy link
Contributor

This reenables the sourcelink support by fixing the condition on the itemgroup that enables the sourcelink functionality.

if the value of EnableSourceLink is true then:

'$(EnableSourceLink)' == 'true' evaluates to 'true' = 'true' evaluates to true

'($EnableSourceLink)' == 'true' evaluates to '($EnableSourceLink)' = 'true' evaluates to false

Reenable SourceLink3 Support

@swoolcock
Copy link
Collaborator

Do the iOS projects build?

@miterosan
Copy link
Contributor Author

This does not regress your changes you did back in #2005.

@peppy
Copy link
Sponsor Member

peppy commented Jan 12, 2019

Whoops.

@peppy peppy merged commit 65ad222 into ppy:master Jan 12, 2019
@miterosan miterosan deleted the Sourcelink_reenable branch February 16, 2019 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peppy peppy peppy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SourceLink isn't working in rider
3 participants
@miterosan @swoolcock @peppy