Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to disable the ManualInputManager cursor guide #3706

Merged
merged 3 commits into from Jul 10, 2020

Conversation

peppy
Copy link
Sponsor Member

@peppy peppy commented Jul 10, 2020

Sometimes it can block what you're trying to test.

@frenzibyte
Copy link
Member

frenzibyte commented Jul 10, 2020

I think it would be better if this gets a visual checkbox instead attached to top-left of the screen, as sometimes it may be useful to know where the mouse is currently located in. so I wouldn't need to go right back to the test scene code, re-enable it and recompile again.

@peppy
Copy link
Sponsor Member Author

peppy commented Jul 10, 2020

If you're willing to implement as such go for it (shouldn't save, just be remembered between tests). It can be a follow-up to this. I still want the ability to change the default state for tests where seeing this is completely irrelevant (OsuRuleset.GameplayCursor test).

@smoogipoo smoogipoo merged commit 19f30a2 into ppy:master Jul 10, 2020
@peppy peppy deleted the manual-input-manager-test-cursor-toggle branch July 17, 2020 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants