Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weight-scheme-fixes #7

Merged
merged 5 commits into from
Jan 6, 2024
Merged

Weight-scheme-fixes #7

merged 5 commits into from
Jan 6, 2024

Conversation

ppillot
Copy link
Owner

@ppillot ppillot commented Jan 6, 2024

Fixes

  • Weight applied twice (squared) in matches score calculation in profile vs profile alignment
  • Weight not applied on gaps in sequence vs profile alignment
  • Error in residue frequence computation when merging profiles

Improvements

  • Simple Matching Distance computation tweaked, so that identical sequences have a distance of 0.

Because profile residue scores are already weighted, multiplying again by the profile weight diminishes the matching score.
As we correct for random matches, they must be substracted from the denominator to have identical sequences getting a distance of 0.
@ppillot ppillot merged commit d0b19ca into master Jan 6, 2024
2 checks passed
@ppillot ppillot deleted the weight-scheme-fixes branch January 6, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant