Improves stream trimming performance by approximating #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements backlogs using streams rather than sorted sets. Streams do their own length limitation. See https://redis.io/topics/streams-intro.
Streams can be long-polled themselves, without the need to duplicate publishing to a PubSub channel.
Every other test does this.
Eliminates Redis PubSub from Streams implementation
Allows the stream to grow a small amount beyond the maximum backlog length until a full macro node can be removed from the radix tree, which is significantly more efficient than being precise and editing nodes. This means we will use an amount of storage equivalent to a few tens of messages more than the maximum backlog length we specify, but throughput will be higher.
benlangfeld
force-pushed
the
redis-streams-approximate-trimming
branch
from
6ec030d
to
d3c274a
Compare
benlangfeld
force-pushed
the
redis-streams
branch
3 times, most recently
from
734fae8
to
daa5d19
Compare
benlangfeld
force-pushed
the
redis-streams
branch
2 times, most recently
from
e30b739
to
18837b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the stream to grow a small amount beyond the maximum backlog length until a full macro node can be removed from the radix tree, which is significantly more efficient than being precise and editing nodes. This means we will use an amount of storage equivalent to a few tens of messages more than the maximum backlog length we specify, but throughput will be higher.