fix: slash some path for windows #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posva
requested changes
Aug 16, 2022
src/core/RoutesFolderWatcher.ts
Outdated
| @@ -41,7 +42,7 @@ export class RoutesFolderWatcher { | |||
| return | |||
| } | |||
| handler({ | |||
| filePath, | |||
| filePath: normalize(filePath), | |||
There was a problem hiding this comment.
let's move filePath = normalize(filePath) up so it's passed to everything
There was a problem hiding this comment.
@posva OK, I'll deal with the problem after work。
Sorry, I didn't pay attention to this, it has been opened |
|
weird, I still can't push even after you ticked the checkbox |
|
I also feel weird 😂. I have submitted changes. Thank you for your patience and teaching. I have learned a lot。 |
posva
reviewed
Aug 16, 2022
posva
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first time we add a path, we use "resolve" of "pathe", which will "slash" the path。
However, when the page is updated later, the "slash" is not used, which will cause the problem of update loss in windows.