Feat/handle ts syntax in define page #238
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posva
reviewed
Sep 28, 2023
Comment on lines
+107
to
+110
| const transformedResults = transformSync( | ||
| `export default ${s.toString()}`, | ||
| { plugins: ['@babel/plugin-transform-typescript'] } | ||
| )?.code |
There was a problem hiding this comment.
Did you benchmark this with vite plugin inspect? I think it's probably too slow 🤔
There was a problem hiding this comment.
I haven't benchmarked it with vite plugin inspect. First time modifying vite plugin. I'll check it a bit later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle TypeScript syntax within definePage()
#57