Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit tests #736

Merged
merged 10 commits into from May 1, 2024
Merged

Fix unit tests #736

merged 10 commits into from May 1, 2024

Conversation

aman-v-singh
Copy link
Contributor

Steps taken to fix unit-tests

  • Replace inactive URLs with the postman-echo.com URL.
  • Comparing only the content and ignoring the whitespaces.

@aman-v-singh
Copy link
Contributor Author

@VShingala The tests are passing now.

@@ -721,11 +721,11 @@
"raw": "Duis posuere augue vel cursus pharetra. In luctus a ex nec pretium. Praesent neque quam, tincidunt nec leo eget, rutrum vehicula magna.\nMaecenas consequat elementum elit, id semper sem tristique et. Integer pulvinar enim quis consectetur interdum volutpat."
},
"url": {
"raw": "https://mockbin.org/request/:action",
"raw": "https://postman-echo.com/request/:action",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://postman-echo.com/request/:action gives 404. Is this correct?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aman-v-singh Even with replacing value of :action to post, the request to the corresponding URL returns 404.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VShingala Fixed it by changing it to https://postman-echo.com/:action

Copy link
Member

@VShingala VShingala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one comment rest looks good.

@VShingala VShingala merged commit 13a946d into develop May 1, 2024
1 check passed
@aman-v-singh aman-v-singh deleted the fix-unit-tests branch May 2, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants