Improve AtRule#nodes type #1921
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ai
reviewed
Feb 3, 2024
| * layer.nodes //=> undefined | ||
| * ``` | ||
| */ | ||
| node: Container['nodes'] | undefined |
There was a problem hiding this comment.
Should it be nodes: instead of node:?
There was a problem hiding this comment.
Yes, sorry. I was wondering why that was working all of a sudden. Because with this change TS is not happy:
Property 'nodes' in type 'AtRule_' is not assignable to the same property in base type 'Container_'.
There was a problem hiding this comment.
I will open a new PR, I already have a branch ready :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing something like
with
postcsswill result in anAtRuleobject without anodesproperty. This however is not reflected by the types.This PR changes the type of
AtRule#nodesfromChildNodes[]toChildNodes[] | undefinedand updates the documentation.I used
Container['nodes']instead ofChildNodes[], I can change that if you prefer it that way. I have also added a unit test to enforce this behavior (AtRule#nodesbeingundefinedwhen the body is missing).Closes #1920.