fromJSON and toJSON #1484
Merged
fromJSON and toJSON #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mischnic
commented
Dec 4, 2020
ai
reviewed
Dec 4, 2020
ai
reviewed
Dec 4, 2020
ai
reviewed
Dec 4, 2020
ai
reviewed
Dec 4, 2020
ai
reviewed
Dec 4, 2020
ai
reviewed
Dec 4, 2020
ai
reviewed
Dec 4, 2020
|
Looks good! 👍 Let’s finish small changes and release under 8.2 |
|
I will release 8.2 on the next week (I need to promote previous 8.1.14 release first since it solved some painful 8.x migration problems) |
This was referenced Mar 7, 2021
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are rather ugly things in here, but let me know what you think...