Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct path resolution when to/from paths match #136

Merged
merged 1 commit into from Sep 19, 2019
Merged

Correct path resolution when to/from paths match #136

merged 1 commit into from Sep 19, 2019

Commits on Aug 27, 2019

  1. Correct path resolution when to/from paths match 

    If you want to run post-css on the following arrangement:

`postcss app/app.css -o app/app.bundle.css`

Postcss-url will then save the copied assets to process.cwd(), which in this case is `.`.  Not correct. It should copy the assets to `app/${assetsPath}`.  

This fix makes it so the assets are correctly copied to the same folder (presumably inside of a `assetsPath`.  

I'm not 100% sure what the intention of the original logic was, but it appeared to be guarding for when there was a missing `to` option.  This will still preserve the original behavior when `to` is !existy and use process.cwd().  Apologies if this understanding is incorrect.
    @bcomnes
    bcomnes committed Aug 27, 2019
    Copy the full SHA
    5279151 View commit details
    Browse the repository at this point in the history