Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser fixes and test coverage #545

Merged
merged 1 commit into from Dec 9, 2023
Merged

parser fixes and test coverage #545

merged 1 commit into from Dec 9, 2023

Conversation

romainmenke
Copy link
Collaborator

@romainmenke romainmenke commented Oct 3, 2023 •
edited

This makes the parser for @import preludes a bit stricter.

RyanZim
RyanZim approved these changes Dec 9, 2023
View reviewed changes
Copy link
Collaborator

@RyanZim RyanZim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; apologies for my terribly slow review here. Please ping me if this happens again.

@RyanZim RyanZim merged commit 3d51fe5 into master Dec 9, 2023
3 checks passed
@RyanZim RyanZim deleted the parser-fixes-and-test-coverage--amiable-irish-setter-9f7fd3e7d0 branch December 9, 2023 16:35
@RyanZim
Copy link
Collaborator

RyanZim commented Dec 9, 2023

@romainmenke at what point should we be releasing your refactors?

@romainmenke
Copy link
Collaborator Author

Thank you for reviewing @RyanZim 🙇
This was the last refactor before the final and largest one.
I've created a clean PR for that here : #548

After that it is all ready to be released 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanZim RyanZim RyanZim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romainmenke @RyanZim