Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add c8 test coverage #533

Merged

Conversation

romainmenke
Copy link
Collaborator

File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 99.48 99.26 100 99.48
postcss-import 100 100 100 100
index.js 100 100 100 100
postcss-import/lib 98.87 98.49 100 98.87
assign-layer-names.js 100 100 100 100
data-url.js 100 100 100 100
join-layer.js 100 100 100 100
join-media.js 100 100 100 100
load-content.js 100 100 100 100
parse-statements.js 97.67 96.66 100 97.67 151-152,165-166
process-content.js 100 100 100 100
resolve-id.js 100 100 100 100

@@ -21,6 +21,7 @@ module.exports = function processContent(
// SugarSS support:
if (ext === ".sss") {
if (!sugarss) {
/* c8 ignore next 3 */
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't check for test coverage for this bit of code because sugarss always exists when running the tests here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Not sure if it's best to ignore it vs. just having the coverage report indicate that we're not actually testing this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also unsure, coverage in itself isn't a clear signal.
100% doesn't mean that everything is tested.
It's just another tool to help write better tests.

@romainmenke romainmenke merged commit 4dbc931 into master Jul 20, 2023
3 checks passed
@romainmenke romainmenke deleted the add-c8-test-coverage--ambitious-falcon-d8cb63aca0 branch July 20, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants