Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async/await and less logic per file #531

Merged
merged 5 commits into from Jul 20, 2023
Merged

async/await and less logic per file #531

merged 5 commits into from Jul 20, 2023

Conversation

romainmenke
Copy link
Collaborator

see :

This pull request doesn't change any logic, test coverage remains the same and all tests pass without change.

  • use async/await
  • split out some functions into separate files to make it easier to read the code.

@romainmenke romainmenke mentioned this pull request Jul 19, 2023
Closed
3 tasks
RyanZim
RyanZim reviewed Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@RyanZim RyanZim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; just a few small suggestions.

lib/apply-media.js Outdated Show resolved Hide resolved
lib/apply-media.js Outdated Show resolved Hide resolved
lib/apply-raws.js Outdated Show resolved Hide resolved
lib/apply-styles.js Outdated Show resolved Hide resolved
lib/parse-styles.js Outdated Show resolved Hide resolved
lib/parse-styles.js Outdated Show resolved Hide resolved
romainmenke and others added 4 commits July 20, 2023 12:03
@romainmenke @RyanZim
Apply suggestions from code review
18826d8 
Co-authored-by: Ryan Zimmerman <opensrc@ryanzim.com>
@romainmenke @RyanZim
Apply suggestions from code review
7f74b57 
Co-authored-by: Ryan Zimmerman <opensrc@ryanzim.com>
@romainmenke
formatting and consistency
c58ee7c
@romainmenke
Merge remote-tracking branch 'origin/master' into async-await-and-les…
8225ef1 
…s-logic-per-file--affectionate-gopher-9eb349f206
@romainmenke
Copy link
Collaborator Author

Thank you for these comments 🙇

@romainmenke romainmenke merged commit fb2db6f into master Jul 20, 2023
3 checks passed
@romainmenke romainmenke deleted the async-await-and-less-logic-per-file--affectionate-gopher-9eb349f206 branch July 20, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanZim RyanZim RyanZim left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romainmenke @RyanZim