Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-TTY stdin watch mode #448

Merged
merged 1 commit into from Nov 29, 2022
Merged

Commits on Nov 28, 2022

  1. Allow non-TTY stdin watch mode

    The presence of stdin doesn't necessarily mean there's an allocated
    tty. This breaks watch mode in non-TTY stdin contexts (e.g. docker,
    foreman, etc). A simple process.stdin.isTTY check would theoretically
    be enough but unfortunately, subprocesses don't have the same API,
    which are used extensively to test via calls to `spawn`.
    
    A simple solution is to inject an env var dependency where we tell
    the process that it's indeed a TTY-allocated process and so, watch mode
    with exit handling is good to go.
    0xradical committed Nov 28, 2022
    Copy the full SHA
    e95f5fc View commit details
    Browse the repository at this point in the history