Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --include-dotfiles option to allow glob to match files/dirs that begin with '.' #254

Merged
merged 1 commit into from Dec 20, 2018
Merged

Conversation

protoEvangelion
Copy link
Contributor

@protoEvangelion protoEvangelion commented Dec 14, 2018

Background: https://github.com/isaacs/node-glob\#dots

My use case is I was trying to use a glob but it would not match the directory I used which begins with a ..

For example:

postcss "src/**/.sass-cache/*" --use autoprefixer --replace

This PR will pass the dot option to globby which is used by fast-glob. Here is what it will look like practically:

postcss "src/**/.sass-cache/*" --dot --use autoprefixer --replace

If user does not pass --dot nothing will change 😄 Please let me know if anything needs to be changed. Thanks for all the postcss crew does by the way. This tool is amazing!!!

@RyanZim
Copy link
Collaborator

RyanZim commented Dec 19, 2018

Would prefer --include-dotfiles, babel uses this option name.

index.js Outdated Show resolved Hide resolved
@RyanZim
Copy link
Collaborator

RyanZim commented Dec 19, 2018

Also, it looks like you forgot to run npm run format to format your code with prettier.

@protoEvangelion
Copy link
Contributor Author

@RyanZim Thanks for the feedback! How does that look?

@RyanZim
Copy link
Collaborator

RyanZim commented Dec 19, 2018

Good; just needs npm run format to fix formatting; then commit the changes, and that should get the CI passing.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 75.694% when pulling 8978745 on protoEvangelion:master into ca69641 on postcss:master.

@protoEvangelion
Copy link
Contributor Author

Done, thanks for your patience 😄

@postcss postcss deleted a comment from coveralls Dec 20, 2018
@RyanZim RyanZim merged commit cd6014b into postcss:master Dec 20, 2018
@RyanZim
Copy link
Collaborator

RyanZim commented Dec 20, 2018

Thanks!

@RyanZim RyanZim changed the title Add --dot option to allow globby to match files/dir that begin with a '.' Add --include-dotfiles option to allow glob to match files/dirs that begin with '.' Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants