New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove text-decoration hack #1474
Conversation
For this to work as expected From the changes alone I could not determine if this was the case. Testing shows that only Safari <= 12 currently receives prefixes for |
This PR won't change the behavior of shorthand |
I think it needs to change to get the intended effect. However see my comment : #1473 (comment) |
I'm not sure I follow, I think that would be a separate issue (probably in browserlist?), as this PR only looks to prefix all values of |
Two things are need to resolve the linked issue :
Maybe best to update the PR comment so that merging this PR doesn't resolve the linked issue? |
I could take a look at it tomorrow if ai wants this fix, but it doesn't seem so 🤷 |
Yes, I really afraid to change old prefixes. I afraid that with the this fix we will break another cases. |
I see. The bug still remains though. Maybe we could find the version of safari or Mozilla you used when implementing it, to see if that gives us a hint as to why you didn't prefix single values? |
@ai Is your concern that people might depend on the current behaviour or that it is difficult to validate this change? If it is the former I agree that this could be a breaking change for some users of autoprefixer. |
My concerns go from:
|
I'm probably blind to the other cases from my point of view, so it's probably a breaking change. I still consider this the correct fix though, as if Safari were to remove the prefix, that would leave the same behavior as this PR introduces. But I'm still lost as to why the check is there in the first place. I'm removing my interest in this issue as we've had to include a rule to never use |
Fixes #1473