-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hack for :placeholder-shown #1312
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
let Selector = require('../selector') | ||
|
||
class PlaceholderShown extends Selector { | ||
static names = [':placeholder-shown'] | ||
|
||
/** | ||
* Return different selectors depend on prefix | ||
*/ | ||
prefixed (prefix) { | ||
if (prefix === '-ms-') { | ||
return ':-ms-input-placeholder' | ||
} | ||
return `:${ prefix }placeholder-shown` | ||
} | ||
} | ||
|
||
module.exports = PlaceholderShown |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -54,6 +54,9 @@ let ffgradienter = autoprefixer({ | |
let selectorer = autoprefixer({ | ||
overrideBrowserslist: ['Chrome 25', 'Firefox > 17', 'IE 10', 'Edge 12'] | ||
}) | ||
let placeholderShowner = autoprefixer({ | ||
overrideBrowserslist: ['IE >= 10'] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure about that |
||
}) | ||
let transitionSpec = autoprefixer({ | ||
overrideBrowserslist: ['Chrome > 19', 'Firefox 14', 'IE 10', 'Opera 12'] | ||
}) | ||
|
@@ -118,6 +121,8 @@ function prefixer (name) { | |
return intrinsicer | ||
} else if (name === 'selectors' || name === 'placeholder') { | ||
return selectorer | ||
} else if (name === 'placeholder-shown') { | ||
return placeholderShowner | ||
} else if (name === 'backdrop-filter' || name === 'overscroll-behavior') { | ||
return overscroller | ||
} else if (name === 'background-clip' || name === 'user-select') { | ||
|
@@ -175,7 +180,8 @@ function check (from, instance = prefixer(from)) { | |
const COMMONS = [ | ||
'transition', 'values', 'keyframes', 'gradient', 'flex-rewrite', | ||
'flexbox', 'filter', 'border-image', 'border-radius', 'notes', 'selectors', | ||
'placeholder', 'fullscreen', 'intrinsic', 'mistakes', 'custom-prefix', | ||
'placeholder', 'placeholder-shown', 'fullscreen', | ||
'intrinsic', 'mistakes', 'custom-prefix', | ||
'cascade', 'double', 'multicolumn', '3d-transform', 'background-size', | ||
'supports', 'viewport', 'resolution', 'logical', 'appearance', | ||
'advanced-filter', 'element', 'image-set', 'image-rendering', | ||
|
@@ -575,6 +581,7 @@ describe('hacks', () => { | |
it('supports logical properties', () => check('logical')) | ||
it('supports appearance', () => check('appearance')) | ||
it('supports all placeholders', () => check('placeholder')) | ||
it('supports placeholder-shown', () => check('placeholder-shown')) | ||
it('supports image-rendering', () => check('image-rendering')) | ||
it('supports border-box mask', () => check('mask-border')) | ||
it('supports mask-composite', () => check('mask-composite')) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
:placeholder-shown { | ||
background: #eee | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
:-ms-input-placeholder { | ||
background: #eee | ||
} | ||
:placeholder-shown { | ||
background: #eee | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,3 @@ | ||
::placeholder { | ||
color: #999 | ||
} | ||
:placeholder-shown { | ||
background: #eee | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,6 +16,3 @@ | |
::placeholder { | ||
color: #999 | ||
} | ||
:placeholder-shown { | ||
background: #eee | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
css-placeholder uses
browsers: browsers.concat(['ie 10 old', 'ie 11 old', 'firefox 18 old'])
here. I don't understand what is 'ie 10 old' vs 'ie 10'.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On my machine it is:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use
old
postfix in flexbox and some other prefixes with 2 syntaxes for the same prefix