update data for text-decoration
#1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainmenke
commented
Sep 13, 2022
|
Looks good. But I have too much work today. We review deeply tomorrow. |
romainmenke
deleted the
update-data-for-text-decoration--resourceful-grey-seal-a428af3a4a
branch
|
@ai thank you for your time reviewing this and for formatting the changes 🎉 |
devongovett
added a commit
to parcel-bundler/lightningcss
that referenced
this pull request
Feb 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for the
text-decorationissue.This ensures that
text-decorationwill be prefixed even in current Safari versions.It also updates the tests related to
text-decoration#1473
I did my best to avoid conflicts with #1474 as both are needed.
But it will be needed to rebase one of these and resolve conflicts.