Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --debug flag; this option is no longer in uvicorn #357

Merged
merged 2 commits into from Oct 20, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Expand Up @@ -14,6 +14,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

* `panel_conditional` now works correctly inside of Shiny modules. (Thanks, @gcaligari!) (#336)

* Fix compatibility with Uvicorn 0.19.0 (#357)

### Other changes


Expand Down
9 changes: 0 additions & 9 deletions shiny/_main.py
Expand Up @@ -63,9 +63,6 @@ def main() -> None:
help="Bind autoreload socket to this port. If 0, a random port will be used. Ignored if --reload is not used.",
show_default=True,
)
@click.option(
"--debug", is_flag=True, default=False, help="Enable debug mode.", hidden=True
)
@click.option("--reload", is_flag=True, default=False, help="Enable auto-reload.")
@click.option(
"--ws-max-size",
Expand Down Expand Up @@ -108,7 +105,6 @@ def run(
host: str,
port: int,
autoreload_port: int,
debug: bool,
reload: bool,
ws_max_size: int,
log_level: str,
Expand All @@ -121,7 +117,6 @@ def run(
host=host,
port=port,
autoreload_port=autoreload_port,
debug=debug,
reload=reload,
ws_max_size=ws_max_size,
log_level=log_level,
Expand All @@ -136,7 +131,6 @@ def run_app(
host: str = "127.0.0.1",
port: int = 8000,
autoreload_port: int = 0,
debug: bool = False,
reload: bool = False,
ws_max_size: int = 16777216,
log_level: Optional[str] = None,
Expand Down Expand Up @@ -165,8 +159,6 @@ def run_app(
autoreload_port
The port that should be used for an additional websocket that is used to support
hot-reload. Set to 0 to use a random port.
debug
Enable debug mode.
reload
Enable auto-reload.
ws_max_size
Expand Down Expand Up @@ -246,7 +238,6 @@ def run_app(
app, # pyright: ignore[reportGeneralTypeIssues]
host=host,
port=port,
debug=debug,
reload=reload,
reload_dirs=reload_dirs,
ws_max_size=ws_max_size,
Expand Down