Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the use of coverage to pytest-cov #345

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

fpgmaas
Copy link
Contributor

@fpgmaas fpgmaas commented Oct 4, 2022

From the pytest-cov website:


This plugin produces coverage reports. Compared to just using coverage run this plugin does some extras:

  • Subprocess support: you can fork or run stuff in a subprocess and will get covered without any fuss.
  • Xdist support: you can use all of pytest-xdist’s features and still get coverage.
  • Consistent pytest behavior. If you run coverage run -m pytest you will have slightly different sys.path (CWD will be in it, unlike when running pytest).

Functionality of make coverage is still exactly the same. It seems coverage was missing from the development requirements, but I added pytest-cov now. I also modified the make test command to output an xml file, in preparation for eventually adding coverage checks to the CI/CD pipeline.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ wch
❌ fpgmaas
You have signed the CLA already but the status is still pending? Let us recheck it.

@wch
Copy link
Collaborator

wch commented Jul 12, 2023

Sorry for the very long delay. If you can sign the CLA, then I'll merge. (Even if you signed the CLA in the past, you may have to sign it again because we updated it to say Posit instead of RStudio.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants