-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(df): Make .input_cell_selection()
return a consistent type shape; Change row order to data view row order
#1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (or `rows`) tuple containing all column (or row) numbers
Note that after we release this, we'll need to update the examples in py-shiny-site. The changes would be a follow-up to posit-dev/py-shiny-site#143. |
wch
approved these changes
May 14, 2024
schloerke
changed the title
feat(df): Make
feat(df): Make May 20, 2024
.input_cell_selection()
return a consistent type shape.input_cell_selection()
return a consistent type shape; Change row order to data view row order
From #1374 (comment)
|
* data_view_meta: Add demo apps for `update_sort()` and `update_filter()` Add `update_sort()` and `update_filter()` to DF bug(output transformer): fix transformer auto-registration (#1394) fix: Add wait till pulse animation has started (#1393) bug(test-deploy): Add retries for deploy tests (#1392) Add busy indicator tests (#1391) Yield to give "synchronous" writes a chance to complete (#1388) chore(busy indicator): Update busy indicator css files (#1389) `ColumnFilter` and `ColumnSort` should use `col: num` and not `id: str` for consistency Lints Have `.data_view()` use `.data_view_info()` information for consistent subsetting feat(cli): Add `shiny --version` (#1387) fix(selectize): Accept jsonifiable values in `options` dictionary (#1382) bug(data frame): Use `<ID>_data_view_rows` (#1386) test(data frame): Verify that data frame's outputs are reset before moving forward (#1383) Send busy/idle at the right times (#1380) feat(data frame): Restore `input.<ID>_selected_rows()`. Rename `input.<ID>_data_view_indices` to `input.<ID>_data_view_rows` (#1377) Apply suggestions from code review
…s the row order provided by user's view
@jcheng5 |
* data_view_meta: `.input_column_sort()` -> `.input_sort()`; `.input_column_filter()` -> `.input_filter()` Add type support for `serialize_numpy_dtype()`; Determine default sorting direction Update controls.py Remove `.data_view_info()` method Add `.data_view_rows()`
Squash merging into base branch for easier PR interactions as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be rebased after #1374 is merged!TODO
Merge feat(data frame): Expose.data_view_rows()
,.input_sort()
,.input_filter()
,.update_sort()
, and.update_filter()
#1374Rebase tomain
Change merge branch tomain
… (orrows
) tuple containing all column (or row) numbers** Update merging into #1374 to get changes
Features for
.input_cell_selection()
:None
return typecols
(orrows
) when theinput
object sent across the wire does not contain the values.Note:
input.<ID>_cell_selection()
's shape did not change. It does not contain missingcols
(orrows
) as that information is always unnecessary.(However, this leads to an awkward user interaction with the code, so
<ID>.input_cell_selection()
upgrades the return value to support the missing keys.)Previous return type for
.input_cell_selection()
:New return type for
.input_cell_selection()
:type = "none"
,rows
andcols
are empty tuples.type = "row"
,cols
is all column numbers of the data.type = "col"
,rows
is all row numbers of the data view rowstype = "rect"
, all rows and cols are provided (no longer just min/max values).Previous user interaction:
New user interaction: