In Express, set session to None
when importing shared
#1082
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one possible solution for #1079.
When it sees
import shared
orfrom shared import ...
at the top level, it puts that within awith session_context(None):
block.One possible limitation is that, if someone does this:
Then that gets transformed into
which means that
module1
would also have the session set toNone
. In practice, it seems unusual for people to put multiple imports on a line like that, but still, it could happen.