Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add security check workflow [CE-220] #4790

Open
wants to merge 28 commits into
base: develop
Choose a base branch
from

Conversation

DimaSalakhov
Copy link
Contributor

@DimaSalakhov DimaSalakhov commented Jan 29, 2021

CE-220

Adds github workflow that:

  • scans both js and go code quality
  • scans go code for security issues
  • scans go dependencies for known vulnerabilities

@DimaSalakhov DimaSalakhov marked this pull request as ready for review January 29, 2021 02:40
@pull-dog
Copy link

pull-dog bot commented Jan 29, 2021

*Ruff* 🐶 It looks like you are currently using the maximum amount of concurrent test environments 😫

You can upgrade your plan to increase that limit, and our plans are quite cheap.

The following pull requests are using environments from your pool as of writing this comment:

You can also see a live list of all test environments if you wish.

What is this?

Pull Dog is a GitHub app that makes test environments for your pull requests using Docker, from a docker-compose.yml file you specify. It takes 19 seconds to set up (we counted!) and there's a free plan available.

Visit our website to learn more.

Commands
  • @pull-dog up to reprovision or provision the server.
  • @pull-dog down to delete the provisioned server.
Troubleshooting

Need help? Don't hesitate to file an issue in our repository

Configuration

{
  "isLazy": false,
  "dockerComposeYmlFilePaths": [
    "docker-compose.pull-dog.yml"
  ],
  "buildArguments": {
    "PORTAINER_TAG": "pr4790-linux-amd64"
  },
  "label": "test-instance-available",
  "expiry": "1.00:00:00",
  "conversationMode": "singleComment"
}

Trace ID
0HM6JTGCOT2NP:00000002

@DimaSalakhov
Copy link
Contributor Author

ref securego/gosec#565
should likely fix the gosec scanning issue

@DimaSalakhov DimaSalakhov changed the title DRAFT: security check workflow feat: add security check workflow Feb 1, 2021
@deviantony
Copy link
Member

@pull-dog down

@DimaSalakhov DimaSalakhov changed the title feat: add security check workflow feat: add security check workflow [CE-220] Feb 10, 2021
@DimaSalakhov DimaSalakhov changed the base branch from develop to fix/ce-51-labels February 18, 2021 01:18
@DimaSalakhov DimaSalakhov changed the base branch from fix/ce-51-labels to develop February 18, 2021 01:19
@oscarzhou-portainer oscarzhou-portainer force-pushed the feat/ce-220-security-scan branch 3 times, most recently from a3211f0 to ec82a3f Compare April 10, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants