Migrating dart:html to package:web #507
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrgetment
reviewed
May 10, 2024
There was a problem hiding this comment.
You need to update index.html check my PR
https://github.com/miguelpruivo/flutter_file_picker/pull/1481/files
Comment on lines
+92
to
+94
| for (final web.HTMLElement tag in tags) { | ||
| web.document.querySelector('head')!.append(tag); | ||
| } |
There was a problem hiding this comment.
querySelector has children, why for loop?
There was a problem hiding this comment.
Can you elaborate on how querySelector having children can help us get rid of the for loop? Maybe a code snippet?
Actually, there is no need to change the example index.html file. The behavior you're referring to is going to change when flutter support for wasm lands on the stable channel. Also making the example project build with wasm is irrelevant to this PR. |
amrgetment
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issue: #498