Removing VALID_ARCHS from pod_target_xcconfig in iOS podspec
#505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #463
Background
Prior to #405, this line matched the flutter plugin template
In #405,
arm64was added toEXCLUDED_ARCHS[sdk=iphonesimulator*]to work around dependencies missingarm64slices for simulator, but that change is no longer necessary: CocoaPods/CocoaPods#10104 (comment).In #425, the line was changed to add
VALID_ARCHS, which is a deprecated build setting (source).Most other common flutter packages don't have
VALID_ARCHSset in their podspec.What changes in this PR
VALID_ARCHSis removed -- it's no longer necessary, and was breaking release builds (#463) for some users