Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wp_tag_cloud() return type for PHPStan #1399

Merged
merged 4 commits into from
Dec 19, 2023
Merged

Conversation

Screenfeed
Copy link
Contributor

@Screenfeed Screenfeed commented Dec 18, 2023

This PR fixes the following issue reported by PHPStan:

 ------ ---------------------------------------------------------------------- 
  Line   admin/admin-filters-term.php                                          
 ------ ---------------------------------------------------------------------- 
         Ignored error pattern #^Parameter \#3 \.\.\.\$values of function      
         sprintf expects bool\|float\|int\|string\|null,                       
         array<string>\|string\|void given\.$# in path                         
         /home/runner/work/polylang/polylang/admin/admin-filters-term.php was  
         not matched in reported errors.                                       
  482    Parameter #3 ...$values of function sprintf expects                   
         bool|float|int|string|null, array<string>|string given.               
 ------ ---------------------------------------------------------------------- 

@Screenfeed Screenfeed added this to the 3.6 milestone Dec 18, 2023
@Screenfeed Screenfeed self-assigned this Dec 18, 2023
@Screenfeed
Copy link
Contributor Author

WTF PHPStan, how?!

@Chouby Chouby merged commit 135ad80 into master Dec 19, 2023
8 checks passed
@Chouby Chouby deleted the fix-tag-cloud-phpstan branch December 19, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants