fix: init functions and AllowPair fields #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
changed the title
|
Nice, thanks! |
|
@polyfloyd could you create a new tag? |
|
Yes! Of course. CI should be running now |
|
Thank you ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
golangci-lint uses
go-errorlintas a lib, theninitfunctions can be a problem because they are always called.The PR removes the need to use
initfunctions:allowedErrorsMapfmt.Errorf, fails error wrap check #21 has been fixed with f57ae32 but aed5641 inverts the expected behavior).The new signature of
NewAnalyzerallows to set use options but the fields ofAllowPairare not exposed, so it's impossible to useWithAllowedErrorsorWithAllowedWildcard.The PR exposes the fields
errandfunof the structureAllowPair.Related to #69