Fix missing bounds check in errorf verb matching (fixes #29)

polyfloyd · Sep 29, 2022 · 28e7f6b · 28e7f6b
1 parent 2a7b31d
commit 28e7f6b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/errorlint/printf.go b/errorlint/printf.go
@@ -14,6 +14,9 @@ func verbOrder(verbs []verb, numArgs int) [][]verb {
 		if v.index != -1 {
 			i = v.index - 1
 		}
+		if i >= len(orderedVerbs) {
+			continue
+		}
 		orderedVerbs[i] = append(orderedVerbs[i], v)
 		verbs = verbs[1:]
 		i++

diff --git a/errorlint/testdata/src/issues/github-29.go b/errorlint/testdata/src/issues/github-29.go
@@ -0,0 +1,8 @@
+package issues
+
+import "fmt"
+
+func Issue29() {
+	err := fmt.Errorf("%v %#[2]v", struct{ string }{})
+	fmt.Println(err)
+}