Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): revert to pydantic 1.7.3 #281

Merged
merged 2 commits into from Mar 3, 2021

Conversation

AntoineDao
Copy link
Member

Pydantic 1.8 breaks the hashing functions somehow. I think we should move to 1.8 once they have
fixed that bug. I am also not sure how to go about testing this bug reliably to avoid future
dependencies update that cause a similar bug...

#280

Pydantic 1.8 breaks the hashing functions somehow. I think we should move to 1.8 once they have
fixed that bug. I am also not sure how to go about testing this bug reliably to avoid future
dependencies update that cause a similar bug...

pollination#280
@coveralls
Copy link

coveralls commented Feb 27, 2021

Pull Request Test Coverage Report for Build 616989475

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 126 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.09%) to 49.078%

Files with Coverage Reduction New Missed Lines %
queenbee/config/repositories.py 6 45.83%
queenbee/recipe/task.py 35 74.51%
queenbee/io/inputs/dag.py 41 58.71%
queenbee/io/inputs/alias.py 44 52.44%
Totals Coverage Status
Change from base Build 603532583: 0.09%
Covered Lines: 1384
Relevant Lines: 2820

💛 - Coveralls

@mostaphaRoudsari
Copy link
Member

Hi @AntoineDao, I think a first good step is to remove auto-merge for queenbee so we can do a double check before merging stuff in.

automerged_updates:
- match:
dependency_type: "all"
update_type: "all"

For this specific issue we can add a test to check the hash for a simple recipe which is not going to be updated - which I assume means will always have the same hash. I'm not sure how to add a normal single test to the fancy parametrized test that you have set up here otherwise I would tried to add one.

@mostaphaRoudsari
Copy link
Member

Also it looks like there will be a 1.8.1 release soon: pydantic/pydantic#2423 (comment)

@AntoineDao
Copy link
Member Author

I am going to merge this in so I can fix the backend dependencies as needed. I have added basic tests to ensure that the hash function does not return None as was the case for pydantic 1.8. I think this is better than changing the automerge on dependabot as if the tests fail dependabot will not merge 😀

@AntoineDao AntoineDao merged commit 2c5f70a into pollination:master Mar 3, 2021
@ladybugbot
Copy link

🎉 This PR is included in version 1.24.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants