Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pydantic 1.8 breaks __hash__ functions #280

Closed
AntoineDao opened this issue Feb 27, 2021 · 1 comment
Closed

Pydantic 1.8 breaks __hash__ functions #280

AntoineDao opened this issue Feb 27, 2021 · 1 comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file released

Comments

@AntoineDao
Copy link
Member

I noticed a bug on honeycomb-simulations whereby some class instances aren't hashing properly. It seems to be linked to the latest version of queenbee where pydantic was upgraded to 1.8. I noticed people reporting similar bugs already.

I will fix honeycomb-simulations manually just now and open a PR to queenbee to revert back to pydantic==1.7.3.
@AntoineDao AntoineDao added bug Something isn't working dependencies Pull requests that update a dependency file labels Feb 27, 2021
AntoineDao added a commit that referenced this issue Feb 27, 2021
@AntoineDao
fix(deps): revert to pydantic 1.7.3
179d93e 
Pydantic 1.8 breaks the hashing functions somehow. I think we should move to 1.8 once they have
fixed that bug. I am also not sure how to go about testing this bug reliably to avoid future
dependencies update that cause a similar bug...

#280
@AntoineDao AntoineDao mentioned this issue Feb 27, 2021
Merged
@mostaphaRoudsari mostaphaRoudsari mentioned this issue Mar 1, 2021
Closed
AntoineDao added a commit to AntoineDao/queenbee that referenced this issue Mar 3, 2021
@AntoineDao
test(hash): add __hash__ test to avoid pydantic 1.8 bug in future
e96cc07 
fix pollination#280
AntoineDao added a commit that referenced this issue Mar 3, 2021
@AntoineDao
fix(deps): revert to pydantic 1.7.3
f54482f 
Pydantic 1.8 breaks the hashing functions somehow. I think we should move to 1.8 once they have
fixed that bug. I am also not sure how to go about testing this bug reliably to avoid future
dependencies update that cause a similar bug...

#280
@ladybugbot
Copy link

🎉 This issue has been resolved in version 1.24.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working dependencies Pull requests that update a dependency file released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AntoineDao @ladybugbot