Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unnamed non-Field elements in pl$Struct() #1053

Merged
merged 3 commits into from
May 22, 2024
Merged

Conversation

etiennebacher
Copy link
Collaborator

Close #1011

Breaking so should be in 0.17.0

@etiennebacher etiennebacher added this to the 0.17 milestone Apr 22, 2024
@etiennebacher
Copy link
Collaborator Author

@eitsupi do you think the next release will be 0.16.4 or 0.17.0? Just wondering since I have a couple of PR that can be merged if the next one is 0.17

@eitsupi
Copy link
Collaborator

eitsupi commented May 6, 2024

I am also worried about this.......
The next release of Rust Polars seems going to be pretty huge, and considering that Python was not even released last week, I think we may have trouble incorporating Rust Polars' breaking changes here.
So I think it would be better to merge in potentially breaking changes like this and #1078, but probably rarely used, and release 0.16.4. (If we follow semantic versioning, all releases prior to 1.0.0 may contain braking changes, so it is acceptable for 0.16.4 to contain breaking changes)

@etiennebacher
Copy link
Collaborator Author

I don't think the next rust-polars release will be a big issue (I mean I don't see why it would be more problematic than the previous ones). Also, this PR and #1050 shouldn't have many conflicts with the next release of rust-polars so I'm fine with waiting the rust-polars update before merging those.

@eitsupi
Copy link
Collaborator

eitsupi commented May 7, 2024

Since #1078 is no longer a breaking change, I would like to merge #1078 and release 0.16.4.

@etiennebacher etiennebacher marked this pull request as ready for review May 7, 2024 17:41
@etiennebacher etiennebacher requested a review from eitsupi May 7, 2024 17:41
@etiennebacher
Copy link
Collaborator Author

etiennebacher commented May 7, 2024

Ah sorry, I understood that you would like to merge this PR but I just misread, back to draft

@etiennebacher etiennebacher marked this pull request as draft May 7, 2024 17:42
@eitsupi
Copy link
Collaborator

eitsupi commented May 22, 2024

Can we merge this?

@eitsupi eitsupi marked this pull request as ready for review May 22, 2024 12:53
@eitsupi eitsupi merged commit e0447c1 into main May 22, 2024
17 of 19 checks passed
@eitsupi eitsupi deleted the struct-named-elements branch May 22, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pl$Struct() must have named elements
2 participants