-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: do not use pyo3-built #16309
perf: do not use pyo3-built #16309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is technically a breaking change.. 🤔
use pyo3::types::{PyDict, PyString}; | ||
let info = PyDict::new_bound(py); | ||
|
||
let build = PyDict::new_bound(py); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's call this variable compiler
too, then?
let build = PyDict::new_bound(py); | |
let compiler = PyDict::new_bound(py); |
We have many more places where we don't regard anything about the exact output. E.g. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16309 +/- ##
==========================================
+ Coverage 80.76% 81.33% +0.57%
==========================================
Files 1393 1403 +10
Lines 179416 183333 +3917
Branches 2921 2924 +3
==========================================
+ Hits 144910 149121 +4211
+ Misses 34003 33709 -294
Partials 503 503 ☔ View full report in Codecov by Sentry. |
This crate only saved us ~50 LOC and included a hidden dependency on
email.utils
increasing our import times.While in the process I also renamed the awkwardly named
pl.build_info()["build"]
topl.build_info()["compiler"]
andpl.build_info()["info-time"]
is now a RFC2822 stringpl.build_info()["time"]
.