Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: do not use pyo3-built #16309

Merged
merged 4 commits into from
May 19, 2024
Merged

perf: do not use pyo3-built #16309

merged 4 commits into from
May 19, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented May 18, 2024

This crate only saved us ~50 LOC and included a hidden dependency on email.utils increasing our import times.

While in the process I also renamed the awkwardly named pl.build_info()["build"] to pl.build_info()["compiler"] and pl.build_info()["info-time"] is now a RFC2822 string pl.build_info()["time"].

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels May 18, 2024
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is technically a breaking change.. 🤔

use pyo3::types::{PyDict, PyString};
let info = PyDict::new_bound(py);

let build = PyDict::new_bound(py);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's call this variable compiler too, then?

Suggested change
let build = PyDict::new_bound(py);
let compiler = PyDict::new_bound(py);

@ritchie46
Copy link
Member

I guess this is technically a breaking change.. 🤔

We have many more places where we don't regard anything about the exact output. E.g. explain, serialization, describe. This can join that list.

Copy link

codecov bot commented May 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.33%. Comparing base (b61a5a9) to head (49e051e).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16309      +/-   ##
==========================================
+ Coverage   80.76%   81.33%   +0.57%     
==========================================
  Files        1393     1403      +10     
  Lines      179416   183333    +3917     
  Branches     2921     2924       +3     
==========================================
+ Hits       144910   149121    +4211     
+ Misses      34003    33709     -294     
  Partials      503      503              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit f70256d into pola-rs:main May 19, 2024
18 checks passed
@c-peters c-peters added the accepted Ready for implementation label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants