Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(python): Overview of available SQL functions #16268

Merged
merged 29 commits into from
Jun 1, 2024

Conversation

r-brink
Copy link
Contributor

@r-brink r-brink commented May 16, 2024

Related to #15575.

@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars rust Related to Rust Polars labels May 16, 2024
@stinodego
Copy link
Member

@r-brink Did you mean to keep this on draft or is this ready to be reviewed?

@stinodego stinodego removed the rust Related to Rust Polars label May 19, 2024
@stinodego stinodego changed the title docs: Overview of available SQL functions docs(python): Overview of available SQL functions May 19, 2024
@r-brink
Copy link
Contributor Author

r-brink commented May 20, 2024

@stinodego I am not a 100% sure if this is the right structure. I have asked @alexander-beedie to have a look. If he thinks its a sustainable approach I will make it ready for review.

@alexander-beedie
Copy link
Collaborator

alexander-beedie commented May 23, 2024

Finally (!) about to build this locally and check it out today 🙏😅

@alexander-beedie
Copy link
Collaborator

(Mouse/keyboard went nuts for a second and somehow closed the issue - reopened 🤣)

@jqnatividad
Copy link
Contributor

Awesome! Would be ideal if the examples also show the expected results...

@r-brink
Copy link
Contributor Author

r-brink commented May 28, 2024

@jqnatividad great idea. When the foundation is in place I will look into extending the examples.

@alexander-beedie alexander-beedie force-pushed the sql-functions-docs branch 7 times, most recently from 04ae36d to 298437c Compare May 30, 2024 21:14
Copy link
Collaborator

@alexander-beedie alexander-beedie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structure is looking good, and a decent percentage of the functions are now covered! Can follow-up with the ones that are still missing (eg: operators, supported function aliases, etc) 😎👍

@ritchie46
Copy link
Member

@alexander-beedie there is a lint error. Can you take a look? Would be nice if we can ship this with the release. :)

@ritchie46 ritchie46 merged commit 15803ce into pola-rs:main Jun 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants